Skip to content

[CHIA-3294] Port get_wallet_balance(s) to @marshal #19774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2025
Merged

[CHIA-3294] Port get_wallet_balance(s) to @marshal #19774

merged 3 commits into from
Aug 5, 2025

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Jul 1, 2025 •
edited
Loading

Another PR following #18593

@Quexington Quexington requested a review from a team as a code owner July 1, 2025 11:23
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jul 1, 2025
@Quexington Quexington changed the title Port get_wallet_balance(s) to @marshal [CHIA-3294] Port get_wallet_balance(s) to @marshal Jul 1, 2025
Base automatically changed from quex.port_get_wallet_to_marshal to main July 16, 2025 16:07
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 16, 2025
@Quexington Quexington force-pushed the quex.port_get_wallet_balance_s_to_marshal branch from 40940de to 954c9c7 Compare July 18, 2025 07:24
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 18, 2025
@Quexington Quexington requested a review from altendky July 18, 2025 07:44
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 16365068299

Details

  • 110 of 113 (97.35%) changed or added relevant lines in 9 files are covered.
  • 18 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.005%) to 91.375%
Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/wallet_funcs.py 3 4 75.0%
chia/cmds/plotnft_funcs.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
chia/cmds/wallet_funcs.py 1 84.89%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/wallet/wallet_node.py 1 87.74%
chia/full_node/full_node.py 6 88.1%
chia/server/node_discovery.py 9 80.32%
Totals Coverage Status
Change from base Build 16332491766: 0.005%
Covered Lines: 102401
Relevant Lines: 111948
💛 - Coveralls

altendky
altendky suggested changes Jul 21, 2025
View reviewed changes
altendky
altendky previously approved these changes Jul 23, 2025
View reviewed changes
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 23, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 24, 2025
@Quexington Quexington closed this Aug 4, 2025
@Quexington Quexington reopened this Aug 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

File Coverage Missing Lines
chia/cmds/plotnft_funcs.py 0.0% lines 165-166
chia/cmds/wallet_funcs.py 75.0% lines 964
Total Missing Coverage
106 lines 3 lines 97%

@Starttoaster Starttoaster merged commit 42da90e into main Aug 5, 2025
691 of 694 checks passed
@Starttoaster Starttoaster deleted the quex.port_get_wallet_balance_s_to_marshal branch August 5, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markelrod markelrod markelrod approved these changes

+1 more reviewer

@altendky altendky altendky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Quexington @altendky @markelrod @Starttoaster